Matrix handler now checks in the background if the matrix is CSR. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonecoldhughes
suggested changes
Sep 25, 2024
pelesh
added a commit
that referenced
this pull request
Sep 25, 2024
stonecoldhughes
approved these changes
Sep 26, 2024
pelesh
force-pushed
the
matrix-handler-types-dev
branch
from
67915e1 to
c2ed0c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since only CSR format is supported by the
MatrixHandlermethods for matrix-vector product and matrix norm, these methods will now check if the matrix is CSR and, if not, return an error. When (if)MatrixHandlersupports other sparse formats, we can add switch to those methods to perform computations specific to the (supported) input matrix format.This PR:
matvecmethod specifying the matrix format.matrix::Sparseclass. Each derived class (Csr,Csc, etc.) sets this ID at construction. This allowsmatvecandmatrixNormto check matrix format "under the hood".MatrixHandler::matrixInfNormshould not assume that the input matrix is in the csr format #180.MatrixHandler::matvecinterface.